sijie commented on a change in pull request #3168: Refactor api commands
URL: https://github.com/apache/pulsar/pull/3168#discussion_r243461634
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SourceBase.java
##########
@@ -127,11 +132,10 @@ public Response deregisterSource(final
@PathParam("tenant") String tenant,
@ApiResponse(code = 404, message = "The function doesn't exist")
})
@Path("/{tenant}/{namespace}/{sourceName}")
- public Response getSourceInfo(final @PathParam("tenant") String tenant,
- final @PathParam("namespace") String
namespace,
- final @PathParam("sourceName") String
sourceName) throws IOException {
- return source.getFunctionInfo(
- tenant, namespace, sourceName);
+ public SourceConfig getSourceInfo(final @PathParam("tenant") String tenant,
Review comment:
This changes Response to SourceConfig, doesn't it break BC?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
