[GitHub] ambition119 edited a comment on issue #3294: [IO] [Kafka] a Kafka source submitted with invalid configuration stucks without consuming from Kafka topics

[GitBox]

ambition119 edited a comment on issue #3294: [IO] [Kafka] a Kafka source 
submitted with invalid configuration stucks without consuming from Kafka topics
URL: https://github.com/apache/pulsar/issues/3294#issuecomment-453418838
 
 
    @merlimat @sijie
   Use 'source create' command we validate the parameter key is included, but 
it does not verify that the value of the key is correct, just new source's 
calss instance, not use 
[Source.open()](https://github.com/apache/pulsar/blob/master/pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSource.java#L55)
 method, so create sucessflully.
    If value is error, should we return the create source failure?
   kafka.yaml info:
   ```file
   configs:
       bootstrapServers: "xxxxxxx"
       groupId: "pulsarUTset"
       topic: "test_kafka_topic"
       fetchMinBytes: 1
       autoCommitEnabled: "true"
       autoCommitIntervalMs: 1000
       sessionTimeoutMs: 3000
   ```
   or
   ```file
   configs:
   ```
   
   command like :
   ```shell
   ./bin/pulsar-admin source create --source-config-file 
~/code/pulsar/pulsar_ms/file/kafka.yaml -t kafka --destination-topic-name 
dest_topic --name kafka_fn
   "Created successfully"
   ```
   when I getstatus return info: 
   ```shell
   $ ./bin/pulsar-admin source getstatus  --name kafka_fn
   {
     "numInstances" : 1,
     "numRunning" : 1,
     "instances" : [ {
       "instanceId" : 0,
       "status" : {
         "running" : true,
         "error" : "",
         "numRestarts" : 0,
         "numReceivedFromSource" : 0,
         "numSystemExceptions" : 0,
         "latestSystemExceptions" : [ ],
         "numSourceExceptions" : 0,
         "latestSourceExceptions" : [ ],
         "numWritten" : 0,
         "lastReceivedTime" : 0,
         "workerId" : "c-standalone-fw-localhost-8080"
       }
     } ]
   }
   ```
   If so,this problem with the content of the pulsar-io module.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services