rdhabalia commented on a change in pull request #3501: [pulsar-broker] Make
non-tls web/broker-service optional
URL: https://github.com/apache/pulsar/pull/3501#discussion_r254848234
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
##########
@@ -101,7 +101,7 @@
category = CATEGORY_SERVER,
doc = "The port for serving binary protobuf requests"
)
- private Integer brokerServicePort = 6650;
+ private Integer brokerServicePort;
Review comment:
> Wouldn't this disable the "clear-text" service by default?
yes. in order to disable it, right now, we are considering that user will
give "clear-text". So, by default if user doesn't provide port then it will be
disable. also [pulsar-service
fails](https://github.com/apache/pulsar/blob/be20d32406f0f72d8cb21ce964b76e65bf604695/pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java#L342)
if user doesn't provide both tls and non-tls ports.
However, I also agree that broker service should start with default port if
none of the port is provided by default. so, we can have multiple options to
disable service on non-tls port
1. user can provide clear-text that will disable it by default.
2. user can explicitly provide -1 value to disable non-tls port else by
default it will listen on non-tls ports
3. if both tls and non-tls ports are not provided then broker will start
service on default non-tls ports.
I think we can do 2nd option to explicitly disable non-tls ports. any
thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
