[GitHub] jerrypeng commented on a change in pull request #3536: Add minimum amount of resources to run setting for functions

[GitBox]

jerrypeng commented on a change in pull request #3536: Add minimum amount of 
resources to run setting for functions
URL: https://github.com/apache/pulsar/pull/3536#discussion_r254928455
 
 

 ##########
 File path: 
pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/WorkerConfig.java
 ##########
 @@ -432,6 +432,11 @@ public boolean getTlsEnabled() {
             + " to the init method of the secretproviderconfigurator"
     )
     private Map<String, String> secretsProviderConfiguratorConfig;
+    @FieldContext(
+            category = CATEGORY_FUNC_RUNTIME_MNG,
+            doc = "A set of the minimum amount of resources functions must 
request.  Support for this depends on function runtime."
+    )
+    private Resources functionInstanceMinResources;
 
 Review comment:
   @sijie the unit test ready covers the case when the new worker config is not 
set:
   
   
https://github.com/apache/pulsar/pull/3536/files#diff-da0caf611f277004fd188d0fc99e3178R179
   
   I will add the config to conf/functions_worker.yml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services