jerrypeng commented on issue #3678: [Pulsar Functions] Add support for multiple sinks/sources in a single NAR file. URL: https://github.com/apache/pulsar/pull/3678#issuecomment-466881983 @david-streamlio this PR looks good to me, but I am unclear how the changes in the PR makes submitting a uber JAR with multiple sources/sinks different from submitting a NAR. Do we need to support submitting with a NAR with multiple sources/sinks if submitting a uber JAR already covers the use cases of multiple sources/sinks in one package? I guess it doesn't hurt, however my concern is that we have always submitted NARs without specifying a classname since there is the a yaml file under META-INF that specifies the default source/sink classname as well as the name of the source/sink. How does that work here? with multiple sources and sinks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
