cckellogg commented on a change in pull request #3625: [Issue
#3436][pulsar-broker] Creating REST Endpoint for non-partitioned topic creation
URL: https://github.com/apache/pulsar/pull/3625#discussion_r260871856
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -140,6 +140,22 @@ public void createPartitionedTopic(@PathParam("tenant")
String tenant, @PathPara
internalCreatePartitionedTopic(numPartitions, authoritative);
}
+ @PUT
+ @Path("/{tenant}/{namespace}/{topic}/nonpartitioned")
Review comment:
What about just /{tenant}/{namespace}/{topic} for the endpoint to create? It
seems more natural and the /nonpartitioned is kind of confusing and seems
inconsistent with the rest of the endpoints for topics. For example we do
/{tenant}/{namespace}/{topic}/stats to get the stats and not
/{tenant}/{namespace}/{topic}/nonpartitioned-stats
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
