ivankelly commented on a change in pull request #3735: Implementing
authentication for Pulsar Functions
URL: https://github.com/apache/pulsar/pull/3735#discussion_r266038911
##########
File path:
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/KubernetesRuntimeFactory.java
##########
@@ -181,6 +193,12 @@ public KubernetesRuntime createContainer(InstanceConfig
instanceConfig, String c
default:
throw new RuntimeException("Unsupported Runtime " +
instanceConfig.getFunctionDetails().getRuntime());
}
+
+ // adjust the auth config to support auth
+ if (instanceConfig.getFunctionAuthenticationSpec() != null) {
+ getAuthProvider().configureAuthenticationConfig(authConfig,
getFunctionAuthData(instanceConfig.getFunctionAuthenticationSpec()));
Review comment:
I don't understand what this call is for?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
