rdhabalia commented on a change in pull request #14382:
URL: https://github.com/apache/pulsar/pull/14382#discussion_r812254050
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java
##########
@@ -168,7 +168,8 @@
* will fail unless {@code blockIfQueueFull=true}. Use {@link
#blockIfQueueFull(boolean)}
* to change the blocking behavior.
*
- * <p>The producer queue size also determines the max amount of memory
that will be required by
+ * <p>The producer queue size also determin@Override
+ es the max amount of memory that will be required by
Review comment:
fixed.
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -439,7 +443,7 @@ public void sendAsync(Message<?> message, SendCallback
callback) {
// validate msg-size (For batching this will be check at the batch
completion size)
int compressedSize = compressedPayload.readableBytes();
- if (compressedSize > ClientCnx.getMaxMessageSize() &&
!this.conf.isChunkingEnabled()) {
+ if (compressedSize > chunkMaxMessageSize &&
!this.conf.isChunkingEnabled()) {
Review comment:
fixed.
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/ProducerBuilder.java
##########
@@ -343,6 +344,15 @@
*/
ProducerBuilder<T> enableChunking(boolean enableChunking);
+ /**
+ * Max chunk message size in bytes. Producer chunks the message if
chunking is enabled and message size is larger
+ * than max chunk-message size. By default, producer chunks based on
max-message size configured at broker.
+ *
+ * @param chunkMaxMessageSize
+ * @return
+ */
Review comment:
added info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
