michaeljmarshall commented on a change in pull request #14458:
URL: https://github.com/apache/pulsar/pull/14458#discussion_r814494767
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1273,6 +1273,17 @@ protected void handleProducer(final CommandProducer
cmdProducer) {
if (!Strings.isNullOrEmpty(initialSubscriptionName)
&& topic.isPersistent()
&&
!topic.getSubscriptions().containsKey(initialSubscriptionName)) {
+ if
(!this.getBrokerService().isAllowAutoSubscriptionCreation(topicName)) {
+ String msg =
+ "Could not create the initial
subscription due to the auto subscription "
+ + "creation is not
allowed.";
+ log.warn("[{}] {} initialSubscriptionName:
{}, topic: {}",
+ remoteAddress, msg,
initialSubscriptionName, topicName);
+ commandSender.sendErrorResponse(requestId,
Review comment:
Great catch @Jason918. @RobertIndie, see
https://github.com/apache/pulsar/pull/14467 for an example.
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
##########
@@ -1273,6 +1273,17 @@ protected void handleProducer(final CommandProducer
cmdProducer) {
if (!Strings.isNullOrEmpty(initialSubscriptionName)
&& topic.isPersistent()
&&
!topic.getSubscriptions().containsKey(initialSubscriptionName)) {
+ if
(!this.getBrokerService().isAllowAutoSubscriptionCreation(topicName)) {
+ String msg =
+ "Could not create the initial
subscription due to the auto subscription "
+ + "creation is not
allowed.";
Review comment:
@RobertIndie - is it documented that the DLQ producer will fail to
create in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
