lhotari opened a new pull request #14502: URL: https://github.com/apache/pulsar/pull/14502
### Motivation PR #9610 made changes in the way that metricsPort is handled in Pulsar Functions Kubernetes Runtime. This broke metrics for Pulsar Functions. ### Additional context There's also an alternative fix #14085 . That PR lacks tests and doesn't handle the case where metrics are disabled by setting metricsPort to an empty value. ### Modifications - pass metricsPort configured in functionRuntimeFactoryConfigs.metricsPort in functions_worker.yml on to KubernetesRuntime in the InstanceConfig instance since #9610 made this change. - handle the case where metricsPort is set to an empty value. In this case, don't add the Prometheus scraping annotations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
