sijie commented on a change in pull request #3876: Add the multi version schema support URL: https://github.com/apache/pulsar/pull/3876#discussion_r269637978
########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java ########## @@ -83,6 +83,7 @@ private final ConnectionPool cnxPool; private final Timer timer; private final ExecutorProvider externalExecutorProvider; + private Map<String, Schema> supportSchemaVersioningSchemaCache = new HashMap<>(); Review comment: either use a concurrent structure or you should synchronize on accessing `supportSchemaVersioningSchemaCache` in `ConsumerImpl`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services