ZW007 commented on issue #14673:
URL: https://github.com/apache/pulsar/issues/14673#issuecomment-1066945135


   > It looks like the support for `optional` keyword in Protobuf 3 was 
introduced from 
[3.15.0](https://github.com/protocolbuffers/protobuf/releases/tag/v3.15.0). 
However, it's only a part of tests and the Pulsar C++ library doesn't rely on 
it.
   > 
   > I think we should update the documents for building C++ client from 
source. For developers, Protobuf 3.15.0 or higher is required. For users, 
Protobuf 3.1.0 or higher is required, and they should add `-DBUILD_TESTS=OFF` 
option to CMake command.
   
   @BewareMyPower Thanks again. Here are the steps I tried:
   
   1. first changed `ByteSizeLong` to `ByteSize` in 
`./pulsar-client-cpp/lib/ProtobufNativeSchema.cc` as stated in question above
   2. `cmake . -DBUILD_TESTS=OFF`
   3. `make`
   
   Here is the screenshot the result, no error but it looks like the build 
stops at 33%, and there are `libpulsar.so` and `libpulsar.a` are in the lib 
folder. Am I good to go?
   
   
![image](https://user-images.githubusercontent.com/45562036/158205049-400c69a6-c245-4886-957d-1e37faf66058.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to