madhavan-narayanan commented on pull request #14613:
URL: https://github.com/apache/pulsar/pull/14613#issuecomment-1070753120
> Currently, there is a method `onPulsarCommand` in the interface
`BrokerInterceptor`, this method could handle all Pulsar commands. If we add
specific methods `txnOpened` and `txnEnded`, I think it's confusing. Do we need
to add events in `BrokerInterceptor` for all commands?
Hi @gaoran10 ,
Unfortunately the command objects available in the onPulsarCommand method
do not have enough context to provide sufficient observability. For e.g the
CommandEndTxnResponse object does not help to know if the transaction was
committed or aborted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
