zymap commented on a change in pull request #14792:
URL: https://github.com/apache/pulsar/pull/14792#discussion_r836010060
##########
File path:
pulsar-package-management/core/src/main/java/org/apache/pulsar/packages/management/core/impl/PackagesManagementImpl.java
##########
@@ -139,12 +139,30 @@ public void initialize(PackagesStorage storage) {
.thenCompose(ignore ->
storage.writeAsync(packagePath(packageName), inputStream));
}
+ /***
+ * @see {@link PackagesManagement#delete}.
+ * At this implements, there is a problem:
+ * Concurrently Another command: `create node` when after "getLogs" and
before "deleteLog",
+ * internal implements is recursive-delete, we could not delete every
children-nodes
+ * To resolve this problem, I submit a issue&PR to bookkeeper reporitory:
+ * https://github.com/apache/bookkeeper/issues/3132
+ * https://github.com/apache/bookkeeper/pull/3133
+ * TODO After the PR merged, change this implements.
Review comment:
Don't we need to change the [bk storage
implementation](https://github.com/apache/pulsar/blob/85c1ba50cb155111f969403a092affd536d9dcb9/pulsar-package-management/bookkeeper-storage/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/BookKeeperPackagesStorage.java#L150)?
If the delete path is not empty, we should throw exception from the delete?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
