michaeljmarshall commented on code in PR #15121: URL: https://github.com/apache/pulsar/pull/15121#discussion_r853371421
########## conf/broker.conf: ########## @@ -764,6 +764,9 @@ saslJaasClientAllowedIds= # Default value `SaslConstants.JAAS_DEFAULT_BROKER_SECTION_NAME`, which is "Broker". saslJaasServerSectionName= +# Secret for SaslRoleTokenSigner. +# Default value `SaslConstants.JAAS_DEFAULT_ROLE_TOKEN_SIGNER_SECRET`, which is "PulsarSecret". +saslJaasServerRoleTokenSignerSecret=PulsarSecret Review Comment: Why don't we leave this blank and force the user to configure it? I agree with @eolivelli that a default secret seems like a security hole. Also, can we supply the secret as a file? Finally, note that the python script that configures these `.conf` files only obfuscates configs with `password` in the name. As it is written, this would not be obfuscated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
