lhotari commented on issue #15207: URL: https://github.com/apache/pulsar/issues/15207#issuecomment-1104784572
> * Update the build to make the target(release) java version to 17, except client modules. It's not just client modules. There are also a few libraries that are shared between the client and the broker. The `maven.compiler.release`, `maven.compiler.target` and `maven.compiler.source` properties should remain `8` for these modules. For all other modules, it's fine to set `maven.compiler.release`, `maven.compiler.target` and `maven.compiler.source` to `17`. > * Merge your pull [Migrate Docker images and CI to Java 17 #14355](https://github.com/apache/pulsar/pull/14355) That has been merged. > * Add integration tests for the different jdk compatibility tests -- I will add more connector tests to CI too. When adding these to the CI, please expand the existing GitHub Actions workflow file `pulsar-ci.yaml`. . https://github.com/apache/pulsar/blob/06ba587fb92eff81785f8d463c85aaa1095292e9/.github/workflows/pulsar-ci.yaml#L333-L339 It's recommended to use the `apachepulsar/java-test-image:latest` docker image for most of the new tests since it's fast to build. It would be useful to refactor the existing Pulsar Java client tests in a way that the same tests cases could be used in an integration test. Otherwise, it will lead to duplication in test logic. Refactoring this could be challenging. One reason is that the current test logic uses inheritance a lot, and that's hard to reuse across different type of tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
