wolfstudy commented on a change in pull request #3854: [issue #3767] support go
function for pulsar
URL: https://github.com/apache/pulsar/pull/3854#discussion_r272283344
##########
File path: pulsar-function-go/pf/instance.go
##########
@@ -227,6 +231,7 @@ func (gi *GoInstance) processResult(msgInput
pulsar.Message, output []byte) {
} else if effectivelyOnce {
panic("in effectively-once
case, this is error.")
}
+ log.Fatal(e)
Review comment:
> Doesn’t panic kill the process for EO?
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
