This is an automated email from the ASF dual-hosted git repository. jerrypeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pulsar.git
The following commit(s) were added to refs/heads/master by this push: new 5a7b177 fix bug when updating function running in effectively-once (#3994) 5a7b177 is described below commit 5a7b1779e41a07b7e8a03d70aceb07b17f4bcfae Author: Boyang Jerry Peng <jerry.boyang.p...@gmail.com> AuthorDate: Sun Apr 7 23:54:23 2019 -0700 fix bug when updating function running in effectively-once (#3994) --- .../src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java index b651ab1..feca138 100644 --- a/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java +++ b/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java @@ -239,7 +239,7 @@ public class CmdFunctions extends CmdBase { @Parameter(names = "--retainOrdering", description = "Function consumes and processes messages in order", hidden = true) protected Boolean DEPRECATED_retainOrdering; @Parameter(names = "--retain-ordering", description = "Function consumes and processes messages in order") - protected boolean retainOrdering; + protected Boolean retainOrdering; @Parameter(names = "--subs-name", description = "Pulsar source subscription name if user wants a specific subscription-name for input-topic consumer") protected String subsName; @Parameter(names = "--parallelism", description = "The function's parallelism factor (i.e. the number of function instances to run)") @@ -370,7 +370,9 @@ public class CmdFunctions extends CmdBase { functionConfig.setProcessingGuarantees(processingGuarantees); } - functionConfig.setRetainOrdering(retainOrdering); + if (retainOrdering != null) { + functionConfig.setRetainOrdering(retainOrdering); + } if (isNotBlank(subsName)) { functionConfig.setSubName(subsName);