Anonymitaet commented on code in PR #15431: URL: https://github.com/apache/pulsar/pull/15431#discussion_r865888532
########## site2/docs/io-elasticsearch-sink.md: ########## @@ -80,6 +80,7 @@ The configuration of the Elasticsearch sink connector has the following properti | `compatibilityMode` | enum (AUTO,ELASTICSEARCH,ELASTICSEARCH_7,OPENSEARCH) | AUTO | | Specify compatibility mode with the ElasticSearch cluster. `AUTO` value will try to auto detect the correct compatibility mode to use. Use `ELASTICSEARCH_7` if the target cluster is running ElasticSearch 7 or prior. Use `ELASTICSEARCH` if the target cluster is running ElasticSearch 8 or higher. Use `OPENSEARCH` if the target cluster is running OpenSearch. | | `token` | String| false | " " (empty string)|The token used by the connector to connect to the ElasticSearch cluster. Only one between basic/token/apiKey authentication mode must be configured. | | `apiKey` | String| false | " " (empty string)|The apiKey used by the connector to connect to the ElasticSearch cluster. Only one between basic/token/apiKey authentication mode must be configured. | +| `stripNonPrintableCharacters` | Boolean| false | true|If stripNonPrintableCharacters is true, all non-printable characters will be removed from the document. | Review Comment: ```suggestion | `stripNonPrintableCharacters` | Boolean| false | true|If `stripNonPrintableCharacters` is true, all non-printable characters are removed from the document. | ``` Write in the simple present tense as much as possible if you are covering facts that were, are, and forever shall be true. https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.e8uqh1awkcnp -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
