jerrypeng commented on a change in pull request #4005: Set key for message when
using function publish
URL: https://github.com/apache/pulsar/pull/4005#discussion_r273264655
##########
File path: pulsar-client-cpp/python/pulsar/functions/context.py
##########
@@ -126,7 +126,8 @@ def record_metric(self, metric_name, metric_value):
@abstractmethod
def publish(self, topic_name, message,
serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None,
callback=None):
"""Publishes message to topic_name by first serializing the message using
serde_class_name serde
- The message will have properties specified if any"""
+ The message will have properties specified if any
Review comment:
I think that should be the default behavior if the user doesn't explicitly
specify the key since that is the behavior for objects returned from the
function. We can add an additional method in which the user can explicitly
specify a key
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
