sijie commented on a change in pull request #3876: Add the multi version schema
support
URL: https://github.com/apache/pulsar/pull/3876#discussion_r273290279
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/AutoProduceBytesSchema.java
##########
@@ -63,14 +56,9 @@ public void validate(byte[] message) {
}
@Override
- public byte[] decode(byte[] bytes, byte[] schemaVersion) {
+ public byte[] decode(byte[] bytes) {
ensureSchemaInitialized();
-
- if (requireSchemaValidation) {
Review comment:
don't we still need to check `requireSchemaValidation`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
