sijie commented on a change in pull request #4005: Set key for message when using function publish URL: https://github.com/apache/pulsar/pull/4005#discussion_r273295700
########## File path: pulsar-client-cpp/python/pulsar/functions/context.py ########## @@ -126,7 +126,8 @@ def record_metric(self, metric_name, metric_value): @abstractmethod def publish(self, topic_name, message, serde_class_name="serde.IdentitySerDe", properties=None, compression_type=None, callback=None): Review comment: can we add a ut or integration test for this? this raises a huge concern to me - we update the implementation but didn't change the interface definition. how can we guarantee the fix is correct? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
