codelipenghui commented on code in PR #15674:
URL: https://github.com/apache/pulsar/pull/15674#discussion_r879223207
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/prometheus/TopicStats.java:
##########
@@ -284,6 +286,11 @@ static void printTopicStats(SimpleTextOutputStream stream,
String cluster, Strin
metric(stream, cluster, namespace, topic, n, c.consumerName(),
c.consumerId(),
"pulsar_consumer_msg_rate_out",
consumerStats.msgRateOut,
splitTopicAndPartitionIndexLabel);
+
+ metric(stream, cluster, namespace, topic, n, c.consumerName(),
c.consumerId(),
Review Comment:
We also need a namespace level metric since some users do not enable the
topic level metrics.
And if the topic level metrics are enabled, we should not the namespace
level metric, otherwise, we will get the same indicator name but with different
labels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
