Technoboy- commented on code in PR #15719:
URL: https://github.com/apache/pulsar/pull/15719#discussion_r880125307
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -715,7 +715,13 @@ private Optional<Pair<String, String>>
getLeastLoadedFromLoadManager(ServiceUnit
public CompletableFuture<Void> unloadNamespaceBundle(NamespaceBundle
bundle) {
// unload namespace bundle
- return unloadNamespaceBundle(bundle,
config.getNamespaceBundleUnloadingTimeoutMs(), TimeUnit.MILLISECONDS);
+ return unloadNamespaceBundle(bundle, true);
+ }
+
+ public CompletableFuture<Void> unloadNamespaceBundle(NamespaceBundle
bundle,
Review Comment:
Really, it's no need. but using the given method with four params is too
long here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
