nicoloboschi commented on code in PR #15638:
URL: https://github.com/apache/pulsar/pull/15638#discussion_r881350316


##########
pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/MetadataStore.java:
##########
@@ -159,4 +159,10 @@ public interface MetadataStore extends AutoCloseable {
      * @return the metadata cache object
      */
     <T> MetadataCache<T> getMetadataCache(MetadataSerde<T> serde);
+
+    /**
+     * Async close the current instance.
+     * @return
+     */
+    CompletableFuture<Void> closeAsync();

Review Comment:
   I will revert it but it is unrelated with the thread leak.
   
   `metadata-store-coordination-service` threads come from 
`CoordinationServiceImpl` and the executor is never shutdown.
   
    



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to