[GitHub] [pulsar] michaeljmarshall commented on a diff in pull request #16045: [fix][proxy] Use correct channel for HAProxyMessage dest address

[GitBox]

michaeljmarshall commented on code in PR #16045:
URL: https://github.com/apache/pulsar/pull/16045#discussion_r898697868


##########
pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java:
##########
@@ -233,7 +233,7 @@ private void writeHAProxyMessage() {
                 InetSocketAddress clientAddress = (InetSocketAddress) 
inboundChannel.remoteAddress();
                 String sourceAddress = 
clientAddress.getAddress().getHostAddress();
                 int sourcePort = clientAddress.getPort();
-                InetSocketAddress proxyAddress = (InetSocketAddress) 
inboundChannel.remoteAddress();
+                InetSocketAddress proxyAddress = (InetSocketAddress) 
outboundChannel.localAddress();

Review Comment:
   @codelipenghui - do you have any insight on this issue? It looks like you 
contributed some of the original code here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org