codelipenghui commented on issue #15859: URL: https://github.com/apache/pulsar/issues/15859#issuecomment-1159322677
> we don't need this cost_time? Although it is not accurate enough. I think we can move out of this proposal. Since we will not select the optimal cluster based on the performance metrics of the cluster. If we really want to do cluster selection based on the metrics, we can add it. Just make the changes focus on the proposal really want to do. The metrics may be a point that needs to consider, but it needs to discuss first. > Because it needs to use the ServiceNameResolver of BinaryProtoLookupService to get the socket address, perhaps should be created a new ServiceNameResolver. Adding a ServiceNameResolver is better. It's confusing to add a health check method in LookupService. > Add a new config healthCheckExpiryTime in the proxy server, it express health check result cache expiry time that unit is seconds. `healtchCheckInternalInSeconds` is more descriptive. And why add to the proxy server? not the broker configuration? It's better to add a new section `Configuration Change` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
