nodece commented on code in PR #16221:
URL: https://github.com/apache/pulsar/pull/16221#discussion_r907999571
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4251,7 +4243,7 @@ private RestException topicNotFoundReason(TopicName
topicName) {
== null ? "has no metadata" : "has zero partitions";
return new RestException(Status.NOT_FOUND, String.format(
"Partitioned Topic not found: %s %s",
topicName.toString(), topicErrorType));
- } else if
(!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if
(!internalGetListAsync(Optional.empty()).join().contains(topicName.toString()))
{
Review Comment:
We need to avoid using the `join()` and `get()`.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4271,7 +4263,7 @@ private CompletableFuture<Topic>
topicNotFoundReasonAsync(TopicName topicName) {
== null ? "has no metadata" : "has zero
partitions";
throw new RestException(Status.NOT_FOUND,
String.format(
"Partitioned Topic not found: %s %s",
topicName.toString(), topicErrorType));
- } else if
(!internalGetList(Optional.empty()).contains(topicName.toString())) {
+ } else if
(!internalGetListAsync(Optional.empty()).join().contains(topicName.toString()))
{
Review Comment:
We need to avoid using the `join()` and `get()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
