[GitHub] [pulsar] BewareMyPower commented on a diff in pull request #16201: [fix][broker] Fix passing incorrect authentication data

[GitBox]

BewareMyPower commented on code in PR #16201:
URL: https://github.com/apache/pulsar/pull/16201#discussion_r908032084


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -512,7 +517,7 @@ protected void 
handlePartitionMetadataRequest(CommandPartitionedTopicMetadata pa
                 lookupSemaphore.release();
                 return;
             }
-            isTopicOperationAllowed(topicName, TopicOperation.LOOKUP, 
getAuthenticationData()).thenApply(
+            isTopicOperationAllowed(topicName, TopicOperation.LOOKUP, 
authenticationData, originalAuthData).thenApply(

Review Comment:
   What's the difference with `isTopicOperationAllowed(topicName, 
TopicOperation.LOOKUP, getAuthenticationData(), null)`? (The 4th `null` 
argument is useless)
   
   - If `originalAuthData` is not null, it will be used in 
`isTopicOperationAllowed`.
   - Otherwise, `authenticationData` will be used in `isTopicOperationAllowed`.
   
   But let's see `getAuthentcationData`:
   
   ```java
       public AuthenticationDataSource getAuthenticationData() {
           return originalAuthData != null ? originalAuthData : 
authenticationData;
       }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org