Jason918 commented on code in PR #16420:
URL: https://github.com/apache/pulsar/pull/16420#discussion_r915512032
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java:
##########
@@ -1562,6 +1562,20 @@ private void
updateLedgersListAfterRollover(MetaStoreCallback<Void> callback) {
store.asyncUpdateLedgerIds(name, getManagedLedgerInfo(), ledgersStat,
callback);
}
+ private void updateLedgersListAfterRollover(MetaStoreCallback<Void>
callback, ManagedLedgerInfo mlInfo) {
Review Comment:
It seems we can just modify in previous method
`updateLedgersListAfterRollover`, not creating new one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
