wangjialing218 opened a new pull request, #16623:
URL: https://github.com/apache/pulsar/pull/16623

   ### Motivation
   
   As #4105, we could config pulsar in container environments through 
environment variables.
   Current, both broker and pulsar tools (admin, client, perf) use `PULSAR_MEM` 
to config jvm memory.
   Consider we create a pod for broker through kubernetes, we set 
`containers.resources.limits.memory` to 25Gi, set env `PULSAR_MEM` to `-Xms10g 
-Xmx10g -XX:MaxDirectMemorySize=10g`, broker will start with this jvm memory 
config.
   When we run pulsar-admin or pulsar-client in this pod, they will start with 
broker's jvm memory config since `PULSAR_MEM` was already set, that will cause 
pod's total memory exceed the limit.
   
   ### Modifications
   Rename `PULSAR_MEM` to `PULSAR_TOOL_MEM` for pulsar tools, we could set 
`PULSAR_TOOL_MEM` through environment variables for pulsar tools, or just use 
the default jvm memory setting.
   
   ### Verifying this change
   
   This change is a trivial rework
   
   ### Documentation
     
   - [x] `doc-not-needed` 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to