merlimat commented on a change in pull request #3904: [go schema] support go 
schema for pulsar-client-go
URL: https://github.com/apache/pulsar/pull/3904#discussion_r277474379
 
 

 ##########
 File path: pulsar-client-go/pulsar/message.go
 ##########
 @@ -66,6 +69,9 @@ type Message interface {
 
        // Get the key of the message, if any
        Key() string
+
+       //Get the de-serialized value of the message, according the configured
+       GetValue(v interface{}) error
 
 Review comment:
   Got it. We don't necessarely need to be consistent with the Schema interface 
though. 
   
   I just saw the same pattern is used for JSON deserialize:
   
   ```
   func Unmarshal(data []byte, v interface{}) error
   ```
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to