liangyepianzhou commented on code in PR #16685:
URL: https://github.com/apache/pulsar/pull/16685#discussion_r925144474
##########
pulsar-transaction/coordinator/src/main/java/org/apache/pulsar/transaction/coordinator/impl/MLTransactionLogImpl.java:
##########
@@ -174,6 +197,12 @@ public void addFailed(ManagedLedgerException exception,
Object ctx) {
public CompletableFuture<Void> deletePosition(List<Position> positions) {
CompletableFuture<Void> completableFuture = new CompletableFuture<>();
+ // Change the flag in ackSet to deleted.
+ for (Position position : positions) {
+ if (position instanceof TxnBatchedPositionImpl batchedPosition){
+ batchedPosition.deleteFromAckSet();
Review Comment:
A little question, If the BacthLog support deletion at the batch index level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
