zymap commented on code in PR #16472:
URL: https://github.com/apache/pulsar/pull/16472#discussion_r929431399
##########
pulsar-functions/runtime/src/main/java/org/apache/pulsar/functions/runtime/kubernetes/KubernetesRuntime.java:
##########
@@ -855,13 +854,8 @@ protected List<String> getExecutorCommand() {
}
private List<String> getDownloadCommand(Function.FunctionDetails
functionDetails, String userCodeFilePath) {
- if (Arrays.stream(PackageType.values()).anyMatch(type ->
Review Comment:
IIRC, when you run this in Kubernetes, the pod needs to download the
function from the function worker. This
[place](https://github.com/apache/pulsar/blob/172a84624f47bb722e6b419de4e239fbb8ecc154/pulsar-functions/worker/src/main/java/org/apache/pulsar/functions/worker/rest/api/ComponentImpl.java#L1481)
only download the function in the function worker and do some validates. So
the download command will run in the function instance and then start the
instance.
So my intention is we should add the packageUrl when the function is
uploading by a package management URL. So the Kubernetes runtime can get the
function package from the package management service, not from the function
worker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
