eolivelli commented on code in PR #16812:
URL: https://github.com/apache/pulsar/pull/16812#discussion_r930847119
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/persistent/DelayedDeliveryTest.java:
##########
@@ -278,7 +278,6 @@ public void
testDelayedDeliveryWithMultipleConcurrentReadEntries()
for (int i = 0; i < N; i++) {
msg = consumer.receive(10, TimeUnit.SECONDS);
receivedMsgs.add(msg.getValue());
- consumer.acknowledge(msg);
Review Comment:
I added that line in the PR that created this problem.
this line made the test pass,
with this "fix" now the test still passes
this test is very interesting because it runs many readMoreEntries() in a
separate thread, simulating the mess that happens inside the broker
it is important to revert this change to the test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
