[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16916: [Improve][Broker]Reduce PartitionedStats local REST call

[GitBox]

Technoboy- commented on code in PR #16916:
URL: https://github.com/apache/pulsar/pull/16916#discussion_r935581296


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -1342,16 +1343,35 @@ protected void 
internalGetPartitionedStats(AsyncResponse asyncResponse, boolean
                 return;
             }
             PartitionedTopicStatsImpl stats = new 
PartitionedTopicStatsImpl(partitionMetadata);
-            List<CompletableFuture<TopicStats>> topicStatsFutureList = 
Lists.newArrayList();
+            List<CompletableFuture<TopicStats>> topicStatsFutureList = new 
ArrayList<>(partitionMetadata.partitions);
+            AtomicBoolean exceptionFlag = new AtomicBoolean(false);

Review Comment:
   `PulsarServerException` throw by `pulsar().getAdminClient()`. If this 
occurs, there will be a fast failed result.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org