thetumbled commented on PR #17009:
URL: https://github.com/apache/pulsar/pull/17009#issuecomment-1209277067
The condition checks if txnID is null,not the Positions.isn't it?
------------------ 原始邮件 ------------------
发件人:
"apache/pulsar"
***@***.***>;
发送时间: 2022年8月9日(星期二) 晚上7:32
***@***.***>;
***@***.******@***.***>;
主题: Re: [apache/pulsar] Correct the prompt message (PR #17009)
@RobertIndie commented on this pull request.
In
pulsar-broker/src/main/java/org/apache/pulsar/broker/transaction/pendingack/impl/PendingAckHandleImpl.java:
> @@ -181,7 +181,7 @@ private void
addIndividualAcknowledgeMessageRequest(TxnID txnID, public void
internalIndividualAcknowledgeMessage(TxnID txnID,
List<MutablePair<PositionImpl, Integer>> positions,
CompletableFuture<Void> completableFuture) {
if (txnID == null) { -
completableFuture.completeExceptionally(new NotAllowedException("Positions can
not be null.")); + completableFuture.completeExceptionally(new
NotAllowedException("txnID can not be null."));
Could you explain it in more detail? Why changed here?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were assigned.Message ID: ***@***.***>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
