poorbarcode commented on code in PR #17070:
URL: https://github.com/apache/pulsar/pull/17070#discussion_r944067594
##########
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/AdminApi2Test.java:
##########
@@ -1386,6 +1397,18 @@ public void testDeleteTenant() throws Exception {
assertFalse(pulsar.getLocalMetadataStore().exists(bundleDataPath).join());
}
+ private TreeSet<String> queryTopicsByNamespace(String namespace){
+ NamespaceName namespaceName = NamespaceName.get(namespace);
+ TreeSet<String> topics = new TreeSet<>();
+ topics.addAll(pulsar.getNamespaceService()
+
.getListOfPersistentTopics(NamespaceName.get(namespace)).join());
+
topics.addAll(pulsar.getPulsarResources().getNamespaceResources().getPartitionedTopicResources()
Review Comment:
Hi @Technoboy-
> I think query getListOfPersistentTopics is enough, because __change_events
is persistent.
already remove the logic that queries non-persistent topic
Hi @codelipenghui
> And we don't need to check partitioned topics? Because we will eventually
create the partitons.
already add the partitioned topics check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
