shibd commented on code in PR #13079:
URL: https://github.com/apache/pulsar/pull/13079#discussion_r949745613
##########
pulsar-client-cpp/lib/stats/ConsumerStatsImpl.h:
##########
@@ -20,47 +20,55 @@
#ifndef PULSAR_CONSUMER_STATS_IMPL_H_
#define PULSAR_CONSUMER_STATS_IMPL_H_
+#include <lib/stats/AsyncCallbackLock.h>
#include <lib/stats/ConsumerStatsBase.h>
#include <lib/ExecutorService.h>
#include <lib/Utils.h>
#include <utility>
+
namespace pulsar {
class ConsumerStatsImpl : public ConsumerStatsBase {
private:
std::string consumerStr_;
- unsigned long numBytesRecieved_ = 0;
- std::map<Result, unsigned long> receivedMsgMap_;
- std::map<std::pair<Result, proto::CommandAck_AckType>, unsigned long>
ackedMsgMap_;
+ ExecutorServicePtr executor_;
Review Comment:
It looks like this member variable is useless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
