AnonHxy commented on code in PR #17251:
URL: https://github.com/apache/pulsar/pull/17251#discussion_r954754533
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java:
##########
@@ -4357,39 +4357,50 @@ private PersistentReplicator
getReplicatorReference(String replName, PersistentT
}
}
+ private CompletableFuture<Void> updatePartitionedTopicMetadataAsync(int
numPartitions) {
+ CompletableFuture<Void> future =
namespaceResources().getPartitionedTopicResources()
+ .updatePartitionedTopicAsync(topicName, p -> new
PartitionedTopicMetadata(numPartitions, p.properties));
+ future.exceptionally(ex -> {
+ // If the update operation fails, clean up the partitions that
were created
+ getPartitionedTopicMetadataAsync(topicName, false,
false).thenAccept(metadata -> {
+ int oldPartition = metadata.partitions;
+ for (int i = oldPartition; i < numPartitions; i++) {
+
topicResources().deletePersistentTopicAsync(topicName.getPartition(i)).exceptionally(ex1
-> {
+ log.warn("[{}] Failed to clean up managedLedger {}",
clientAppId(), topicName,
+ ex1.getCause());
+ return null;
+ });
+ }
+ }).exceptionally(e -> {
+ log.warn("[{}] Failed to clean up managedLedger", topicName,
e);
+ return null;
+ });
+ return null;
+ });
+ return future;
+ }
private CompletableFuture<Void> updatePartitionedTopic(TopicName
topicName, int numPartitions, boolean force) {
CompletableFuture<Void> result = new CompletableFuture<>();
- createSubscriptions(topicName, numPartitions).thenCompose(__ -> {
- CompletableFuture<Void> future =
namespaceResources().getPartitionedTopicResources()
- .updatePartitionedTopicAsync(topicName, p ->
- new PartitionedTopicMetadata(numPartitions,
p.properties));
- future.exceptionally(ex -> {
- // If the update operation fails, clean up the partitions that
were created
- getPartitionedTopicMetadataAsync(topicName, false,
false).thenAccept(metadata -> {
- int oldPartition = metadata.partitions;
- for (int i = oldPartition; i < numPartitions; i++) {
-
topicResources().deletePersistentTopicAsync(topicName.getPartition(i)).exceptionally(ex1
-> {
- log.warn("[{}] Failed to clean up managedLedger
{}", clientAppId(), topicName,
- ex1.getCause());
+ createSubscriptions(topicName, numPartitions).thenCompose(
+ __ ->
updatePartitionedTopicMetadataAsync(numPartitions))
+ .thenAccept(__ -> result.complete(null))
+ .exceptionally(ex -> {
+ if (force && ex.getCause() instanceof
PulsarAdminException.ConflictException) {
+ log.warn("[{}] update partitioned topic's partition
num {} with ignoring conflict exception",
Review Comment:
> The createSubscriptions can make sure all the subscriptions are created
because of the internal FutureUtil.waitForAll .
What if one of the subscriptions throw a non ConflictException, for
example:
- There are 100 subs in the topic.
- When 'createSubscriptions', the 1st future throws `ConflictException`,
and others throw non `ConflictException` , we will miss creating some
subscriptions.
So we'd better handle the `ConflictException` in `createSubscriptions()`
method @HQebupt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
