AnonHxy commented on PR #17374: URL: https://github.com/apache/pulsar/pull/17374#issuecomment-1232943532
Nice catch. The code below hide the exception, that's why the test can pass without throw exception. I think the code below wants to try to solve the same problem as https://github.com/apache/pulsar/pull/17251, but has some problem. I think that we can also remove the code from Line4399-Line4402. Because https://github.com/apache/pulsar/pull/17251 fix it better. WDYT @TakaHiR07 https://github.com/apache/pulsar/blob/dab0d1f389ee66277c8350072af304895619eb9a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java#L4398-L4405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
