cbornet opened a new pull request, #17474:
URL: https://github.com/apache/pulsar/pull/17474
Fixes #15392
### Motivation
This reverts commit 1e9a1f087e8c6fd9e78f6e3f0635113ba7927bbf.
When using a `log-topic` in Functions, an appender is added to all loggers
to send the logs with the Pulsar client.
To prevent sending logs from the framework, the `LogAppender` is added
before the function processing (`JavaInstance::handleMessage`) and removed just
after.
This is a problem because since #15188, the logs are sent asynchronously and
sometimes we remove the appender before the log is processed by the
`LogAppender`.
And this is the reason why we see flakyness in `testJavaLoggingFunction`
because me miss some logs.
See also #17471 that proposes another way to solve the issue but that maybe
deserves more discussions.
### Modifications
This reverts commit 1e9a1f087e8c6fd9e78f6e3f0635113ba7927bbf.
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe
tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads
(10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
