codelipenghui commented on code in PR #17269:
URL: https://github.com/apache/pulsar/pull/17269#discussion_r966662477
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/intercept/BrokerInterceptors.java:
##########
@@ -93,107 +97,143 @@ public static BrokerInterceptor load(ServiceConfiguration
conf) throws IOExcepti
}
Review Comment:
Looks like we don't need to return DISABLED here?
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -326,6 +326,9 @@ public void channelInactive(ChannelHandlerContext ctx)
throws Exception {
if (producerFuture.isDone() &&
!producerFuture.isCompletedExceptionally()) {
Producer producer = producerFuture.getNow(null);
producer.closeNow(true);
+ if (brokerInterceptor != null) {
+ brokerInterceptor.producerClosed(this, producer,
producer.getMetadata());
+ }
Review Comment:
Looks like we don't need if check here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
