gaoran10 commented on code in PR #17704:
URL: https://github.com/apache/pulsar/pull/17704#discussion_r973878222
##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/stats/prometheus/PrometheusMetricsGeneratorUtils.java:
##########
@@ -67,14 +68,21 @@ public static void
generateSystemMetrics(SimpleTextOutputStream stream, String c
stream.write(sample.name);
if (!sample.labelNames.contains("cluster")) {
Review Comment:
Maybe we can add this `stream.write("{");` before this check. The char `{`
is necessary and it's easier to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
