heesung-sn commented on code in PR #17828:
URL: https://github.com/apache/pulsar/pull/17828#discussion_r979271694
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TableViewTest.java:
##########
@@ -222,7 +222,6 @@ public void testPublishNullValue() throws Exception {
assertEquals(tv.get("key2"), "value2");
}
-
Review Comment:
I see an internal data structure change for the `reader` member in
TableView. The `testAck` in the master branch will fail in 2.10 branch.
2.10
`private final ConcurrentMap<String, Reader<T>> readers;`
master
`private final CompletableFuture<Reader<T>> reader;`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
