lordcheng10 commented on code in PR #17753:
URL: https://github.com/apache/pulsar/pull/17753#discussion_r981065943
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/PositionImpl.java:
##########
@@ -94,6 +94,14 @@ public PositionImpl getNext() {
}
}
+ public PositionImpl getPositionAfterEntries(int entryNum) {
+ if (entryId < 0) {
Review Comment:
Sorry, didn't understand.
delete this judgment?
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpReadEntry.java:
##########
@@ -100,8 +100,8 @@ public void readEntriesFailed(ManagedLedgerException
exception, Object ctx) {
} else if (cursor.config.isAutoSkipNonRecoverableData() && exception
instanceof NonRecoverableLedgerException) {
log.warn("[{}][{}] read failed from ledger at position:{} : {}",
cursor.ledger.getName(), cursor.getName(),
readPosition, exception.getMessage());
- // try to find and move to next valid ledger
- final Position nexReadPosition =
cursor.getNextLedgerPosition(readPosition.getLedgerId());
Review Comment:
OK, I will fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
