tisonkun commented on code in PR #234:
URL: https://github.com/apache/pulsar-site/pull/234#discussion_r982050960


##########
site2/tools/release-json-gen.sh:
##########
@@ -51,12 +51,12 @@ do
 done
 
 # gh auth login, ref: 
https://github.com/apache/pulsar-site/blob/760f7b47f437267a3c9d71d14c73e99ba32bd1ec/site2/website-next/scripts/release-notes.sh#L31-L33
-echo "$GH_TOKEN" > "$TOKEN_FILE"
+echo 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 > "$TOKEN_FILE"

Review Comment:
   @urfreespace who is associated with this token, are you? Could you clarify 
what permissions are associated with this token?
   
   We'd better replace all literal tokens, regardless of read-only or 
read-write, with GitHub secrets via INFRA team members. I believe they always 
respond in hours.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to