HQebupt commented on code in PR #17872:
URL: https://github.com/apache/pulsar/pull/17872#discussion_r982467524
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -832,8 +833,7 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle bundle,
NamespaceBundleSplitAlgorithm
splitAlgorithm,
List<Long> boundaries) {
BundleSplitOption bundleSplitOption;
- if (config.getDefaultNamespaceBundleSplitAlgorithm()
-
.equals(NamespaceBundleSplitAlgorithm.FLOW_OR_QPS_EQUALLY_DIVIDE)) {
+ if (splitAlgorithm instanceof
FlowOrQpsEquallyDivideBundleSplitAlgorithm) {
Review Comment:
Good catch. Left a minor suggestion. Please add a test to avoid regression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
