liangyepianzhou commented on code in PR #17777:
URL: https://github.com/apache/pulsar/pull/17777#discussion_r983129366
##########
pulsar-client/src/main/java/org/apache/pulsar/client/impl/transaction/TransactionImpl.java:
##########
@@ -61,8 +64,12 @@ public class TransactionImpl implements Transaction ,
TimerTask {
private final Map<Pair<String, String>, CompletableFuture<Void>>
registerSubscriptionMap;
private final TransactionCoordinatorClientImpl tcClient;
- private final ArrayList<CompletableFuture<MessageId>> sendFutureList;
- private final ArrayList<CompletableFuture<Void>> ackFutureList;
+ private CompletableFuture<MessageId> sendFuture;
+ private CompletableFuture<Void> ackFuture;
+
+ private final AtomicLong ackCount = new AtomicLong(0);
+ private final AtomicLong sendCount = new AtomicLong(0);
Review Comment:
We do need an AtomicLong for each Transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
