eolivelli commented on code in PR #17870:
URL: https://github.com/apache/pulsar/pull/17870#discussion_r983433654
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -332,6 +334,10 @@ public PulsarService(ServiceConfiguration config,
this.ioEventLoopGroup =
EventLoopUtil.newEventLoopGroup(config.getNumIOThreads(),
config.isEnableBusyWait(),
new DefaultThreadFactory("pulsar-io"));
+ // A shared io event group for broker clients to avoid internal
clients from occupying IO
+ // threads for a long time and affecting the throughput of the broker.
+ this.brokerClientSharedIoEventLoopGroup =
EventLoopUtil.newEventLoopGroup(config.getNumIOThreads(),
+ config.isEnableBusyWait(), new
DefaultThreadFactory("broker-client-shared-io"));
Review Comment:
I am not sure that busyWait applies here.
I would force it to false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
